Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MapView.md #3409

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

SethArchambault
Copy link

fixed h3 markdown

Description

Fixes #

Added your feature that allows ...

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

Screenshot OR Video

Component to reprocuce the issue you're fixing

fixed h3 markdown
@mfazekas
Copy link
Contributor

mfazekas commented Mar 7, 2024

@SethArchambault thank much but this is a generated file and needs to be fixed in the template

@VolkerLieber
Copy link
Contributor

As @mfazekas already mentioned, this has to be fixed in either:
scripts\templates\component.md.ejs

<%- getMarkdownMethodExamples(method) %>
<%- exampleMethodLinks(method, component) -%>


<%_ } _%>

Which would add additional new lines to all method definitions, which does not look nice (and already happens sometimes)

or

scripts\autogenHelpers\globals.mjs

export function exampleMethodLinks(method, component) {
  const key = `${component.name}#${method.name}`;
  if (global.exampleTagLinks[key]) {
    return global.exampleTagLinks[key]
      .map(({ groupName, name, title }) => {
        return `[${title}](../examples/${groupName}/${name})`;
      })
      .join(', ')
      .concat('\n\n');
  }
  return '';
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants